chore: Remove dependency on Gson #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarsilv
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Nice! Approving this as its certainly one way to go. I do know one customer was interested in keeping dependencies down for the android build, so there was talk of consolidating to what Android uses, org.json vs com.fasterxml.jackson. Any particular reason for one or the other?
Comment on lines
+7
to
+12
| private final String key; | ||
| private final boolean enabled; | ||
| private final int totalShards; | ||
| private final VariationType variationType; | ||
| private final Map<String, Variation> variations; | ||
| private final List<Allocation> allocations; |
There was a problem hiding this comment.
Nice job migrating the DTOs to be immutable 💪
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had a duplicate JSON library dependency on both Jackson and Gson.
This change consolidates all json serialization/deserialization into Jackson, removing Gson completely.
Also made some models immutable for good measure. All tests still pass. Moved some tests from the android-sdk codebase into here since they belong here